[ 
https://issues.apache.org/jira/browse/LUCENE-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033527#comment-13033527
 ] 

Robert Muir commented on LUCENE-1421:
-------------------------------------

{quote}
Only the SearchGroup class had different visibility compared to the patch. And 
Michael says he is going to change that. So I think a patch for that is a bit 
overkill.
{quote}

Ok, thanks for taking a look... I just figured we could tackle any visibility 
issues at once, but it seems this is the only one.

{quote}
I haven't see an issue regarding post faceting yet. I can create one if 
necessary?
{quote}

Sure! of course it will unfortunately need to be blocked on LUCENE-3079, but it 
seems like a good idea to have the issue open for planning.

{quote}
The question is how to go from here. Continue development in this issue or for 
each new grouping related feature a separate issue?
E.g. think about class hierarchy / strategy for grouping collectors. And new 
collectors like UniqueFieldValueCountGroupCollector.
{quote}

My opinion would be to open new issues for each new grouping feature! This way 
things can get committed faster and its easier to
review patches (when there are enormous jira issues with a mix of unrelated 
patches its pretty difficult to keep up with what is happening).

These apis are marked experimental so I don't think we should waste time on 
backwards compatibility, nor should we try to come up with
"holy grail" solutions that solve everyones problems in one single commit... I 
think we should go iteratively. Patches welcome!


> Ability to group search results by field
> ----------------------------------------
>
>                 Key: LUCENE-1421
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1421
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>            Reporter: Artyom Sokolov
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-1421.patch, LUCENE-1421.patch, 
> lucene-grouping.patch
>
>
> It would be awesome to group search results by specified field. Some 
> functionality was provided for Apache Solr but I think it should be done in 
> Core Lucene. There could be some useful information like total hits about 
> collapsed data like total count and so on.
> Thanks,
> Artyom

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to