[
https://issues.apache.org/jira/browse/LUCENE-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824415#comment-15824415
]
Uwe Schindler commented on LUCENE-7631:
---------------------------------------
Thanks Mike!
I am for using this patch. Robert's suggestion was to enable "all" warnings,
but IMHO this is a bad idea, because if somebody compiles with a later Java
version, the build may suddenly fail (because a later version of the compiler
added a new warning type).
I am not sure if the warning exclusions are really needed, because we no longer
have the general {{-Xlint}}. But it's good to have them listed!
The only downside of this patch is that we no longer get any warnings displayed
that are currently disabled (rawtypes, unchecked). So we should fix them asap
(in a separate issue).
BTW: Maybe we can enable rawtypes and unchecked errors earlier in Lucene and
leave them disabled in Solr. As far as I remember we already have a separate
warning setting for Solr. This may be the reason why Solr does not show any
problems!?
> Enforce javac warnings
> ----------------------
>
> Key: LUCENE-7631
> URL: https://issues.apache.org/jira/browse/LUCENE-7631
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Reporter: Mike Drob
> Attachments: LUCENE-7631.patch
>
>
> Robert's comment on LUCENE-3973 suggested to take an incremental approach to
> static analysis and leverage the java compiler warnings. I think this is easy
> to do and is a reasonable change to make to protect the code base for the
> future.
> We currently have many fewer warnings than we did a year or two years ago and
> should ensure that we do not slide backwards.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
