[
https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reopened LUCENE-7559:
----------------------------------
Reopening. [~dweiss] helpfully pointed out that the {{OffsetsEnum}} class in
the UnifiedHighlighter should also have it's methods be made public, otherwise
someone subclassing to override {{FieldHighlighter#highlightOffsetsEnums}}
can't really do anything useful. And doing that is the primary motivation for
making Passage extensible.
Additionally, it'd be good to add a basic test in
TestUnifiedHighlighterExtensibility showing we got this right.
> UnifiedHighlighter: Make Passage public for extensibility
> ---------------------------------------------------------
>
> Key: LUCENE-7559
> URL: https://issues.apache.org/jira/browse/LUCENE-7559
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 6.4
>
> Attachments: LUCENE-7559.patch
>
>
> (UnifiedHighlighter) Passage.java has a variety of package-level fields and
> methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the
> kernel of the UH). It should be possible for people to extend this method to
> tweak the process of producing passages. That method is extensible but
> Passage.java is too closed. Even if one were to write their own equivalent
> to Passage.java, it would be impossible to then use PassageScorer or
> PassageFormatter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
