[
https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764087#comment-15764087
]
Mikhail Khludnev edited comment on SOLR-7115 at 1/4/17 3:10 PM:
----------------------------------------------------------------
[[email protected]]
bq. I don't know if the patch to DUH2 is needed for other reasons
SOLR-9712 prevents max Warming Searcher exception. But any other exception
might lead to skipping line
https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java#L646
and leaking transaction log. Isn't it's worth to be protected with finally?
was (Author: mkhludnev):
[[email protected]]
bq. I don't know if the patch to DUH2 is needed for other reasons
SOLR-7912 prevents max Warming Searcher exception. But any other exception
might lead to skipping line
https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java#L646
and leaking transaction log. Isn't it's worth to be protected with finally?
> UpdateLog can miss closing transaction log objects.
> ---------------------------------------------------
>
> Key: SOLR-7115
> URL: https://issues.apache.org/jira/browse/SOLR-7115
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Yonik Seeley
> Fix For: 6.x, master (7.0)
>
> Attachments: SOLR-7115-LargeVolumeEmbeddedTest-fail.txt,
> SOLR-7115.patch, SOLR-7115.patch, tests-failures-7115.txt
>
>
> I've seen this happen on YourKit and in various tests - especially since
> adding resource release tracking to the log objects. Now I've got a test that
> catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it
> because we are going to overwrite prevTlog with a new log.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
