[
https://issues.apache.org/jira/browse/LUCENE-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735145#comment-15735145
]
Christine Poerschke commented on LUCENE-7586:
---------------------------------------------
bq. I don't fully understand the issue description. ... - so how does that
relate to each other?
Apologies, I was trying to provide context for this small patch and caused
confusion. The logical sequence of things was that I
* saw the Java Warnings (listing and trend chart) on
https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/
* made [1 line
change|https://git1-us-west.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=cacabc9a]
to fix one really easy (varargsArgumentNeedCast) warning listed
* was curious about other varargsArgumentNeedCast warnings in the codebase
(Jenkins hadn't listed any but I didn't know if all the codebase was covered)
* made change to and tested ecj.javadocs.prefs + org.eclipse.jdt.core.prefs (no
further varargsArgumentNeedCast warnings found in the codebase)
* created this ticket with attached patch (and wished to mention that Jenkins'
listing had led to this)
Yes, the extra check is only for Eclipse compiler and setup but still worth
having?
On a related but separate note an IntelliJ equivalent for Eclipse's
[org.eclipse.jdt.core.compiler.problem.???=error|https://github.com/apache/lucene-solr/blob/master/dev-tools/eclipse/dot.settings/org.eclipse.jdt.core.prefs#L307-L309]
might be a nice-to-have.
> fail precommit on varargsArgumentNeedCast
> -----------------------------------------
>
> Key: LUCENE-7586
> URL: https://issues.apache.org/jira/browse/LUCENE-7586
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7586.patch
>
>
> Why this, why now?
> I had noticed the Java Warnings (listing and trend chart) on [~thetaphi]'s
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/ and after fixing
> one really easy warning got curious about others of the same category. There
> aren't any and so it would seem obvious to update the precommit checks (and
> Eclipse settings) to prevent future introductions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
