[
https://issues.apache.org/jira/browse/LUCENE-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenczi Jim updated LUCENE-7575:
---------------------------------
Attachment: LUCENE-7575.patch
Thanks [~dsmiley] and [~Timothy055] !
I pushed a new patch to address your comments.
{quote}
it'd be interesting if instead of a simple boolean toggle, if it were a
Predicate<String> fieldMatchPredicate so that only some fields could be
collected in the query but not all. Just an idea.
{quote}
I agree and this is why I changed the patch to include your idea. By default
nothing changes, queries are extracted based on the field name to highlight.
Though with this change the user can now define which query (based on the field
name) should be highlighted. I think it's better like this but I can revert if
you think this should not implemented in the first iteration.
I fixed the bugs that David spotted (terms from different fields not sorted
after filteredExtractTerms and redundant initialization of the filter leaf
reader for the span queries) and split the tests based on the type of query
that is tested.
> UnifiedHighlighter: add requireFieldMatch=false support
> -------------------------------------------------------
>
> Key: LUCENE-7575
> URL: https://issues.apache.org/jira/browse/LUCENE-7575
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Attachments: LUCENE-7575.patch, LUCENE-7575.patch
>
>
> The UnifiedHighlighter (like the PostingsHighlighter) only supports
> highlighting queries for the same fields that are being highlighted. The
> original Highlighter and FVH support loosening this, AKA
> requireFieldMatch=false.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
