[ 
https://issues.apache.org/jira/browse/SOLR-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667886#comment-15667886
 ] 

Hoss Man commented on SOLR-9442:
--------------------------------

bq. What do you think?

Well, I guess don't really see what usecases the "arrnvp" format (already 
committed) serves that aren't equally/better served with the "arrntv" format 
... if you find it more useful then what I suggested then i guess it has a 
purpose as well ... i'm just not seeing it.

I suppose my main concern with having both is making sure the tests/docs make 
it very clear how things behave with either the name or the value (or both) are 
null.

Even after reading the original diff for this issue it's not clear to me what 
JSON attribute(s) will exist for the equivalents of things like {{<null 
name="bar"/>}} or {{<null/>}} since there is no "type" to use as a JSON 
attribute name ... or does that just result in something like...

{noformat}
NamedList("bar”=null,null=true,null=null)
  => [{"name":"bar"},
      {"bool":true},
      {}]
{noformat}

...which seems really weird)

> Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
> ------------------------------------------------------------------------
>
>                 Key: SOLR-9442
>                 URL: https://issues.apache.org/jira/browse/SOLR-9442
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Response Writers
>            Reporter: Jonny Marks
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: master (7.0), 6.4
>
>         Attachments: SOLR-9442-arrntv.patch, SOLR-9442.patch, 
> SOLR-9442.patch, SOLR-9442.patch
>
>
> The JSONResponseWriter class currently supports several styles of NamedList 
> output format, documented on the wiki at http://wiki.apache.org/solr/SolJSON 
> and in the code at 
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java#L71-L76.
> For example the 'arrmap' style:
> {code}NamedList("a"=1,"b"=2,null=3) => [{"a":1},{"b":2},3]
> NamedList("a"=1,"bar”=“foo",null=3.4f) => [{"a":1},{"bar”:”foo"},{3.4}]{code}
> This patch creates a new style ‘arrnvp’ which is an array of named value 
> pairs. For example:
> {code}NamedList("a"=1,"b"=2,null=3) => 
> [{"name":"a","int":1},{"name":"b","int":2},{"int":3}]
> NamedList("a"=1,"bar”=“foo",null=3.4f) => 
> [{"name":"a","int":1},{"name":"b","str":"foo"},{"float":3.4}]{code}
> This style maintains the type information of the values, similar to the xml 
> format:
> {code:xml}<lst name=“someField”>
>       <int name=“a”>1</int>
>       <str name=“bar”>foo</str>
>       <float>3.4</float>
> </lst>{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to