[ 
https://issues.apache.org/jira/browse/SOLR-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar updated SOLR-9633:
----------------------------------------
    Attachment: SOLR-9633.patch

Thanks Yonik and Michael for the reviews. This patch wrap all updates to 
ramBytes in the put() method with the check as requested. I'll commit shortly.

Michael, to your comment on this working only with Accountable, the example 
configurations specify this parameter only for filterCache so I feel it is 
unlikely that users will try to use FastLRUCache with maxRamMB for something 
else. But I'll make sure to include this point in the reference guide when 
documenting this feature.

> Limit FastLRUCache by RAM Usage
> -------------------------------
>
>                 Key: SOLR-9633
>                 URL: https://issues.apache.org/jira/browse/SOLR-9633
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Shalin Shekhar Mangar
>             Fix For: master (7.0), 6.4
>
>         Attachments: SOLR-9633.patch, SOLR-9633.patch
>
>
> SOLR-7372 added a maxRamMB parameter to LRUCache to evict items based on 
> memory usage. That helps with the query result cache but not with the filter 
> cache which defaults to FastLRUCache. This issue intends to add the same 
> feature to FastLRUCache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to