> > > * Collections API - > > http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/collections-api.html > > ** Shouldn't have a "On this Page" tree > > ** API entry point section is missing new lines > We'll have to fix the new lines manually - it isn't a proper list in > Confluence, so isn't getting exported with proper HTML tags, so > conversion doesn't know what to do with them.
> I don't understand why it shouldn't have an "On this Page" tree, though? Well I guess the page can have it, but the formatting is going to have to be reviewed. Maybe multiple columns or something. It takes up a lot of space when the first thing I've been going to is API Entry Points since that is basically the same as "On this Page". Kevin Risden On Fri, Sep 23, 2016 at 9:51 AM, Cassandra Targett <[email protected]> wrote: > One thing to note is I just realized I had uploaded an old build - I > think I switched branches before I uploaded (I somehow always forget > that impacts the actual files I'm looking at :-| ). I fixed this just > a few minutes ago. > > On Fri, Sep 23, 2016 at 9:22 AM, Kevin Risden <[email protected]> > wrote: > > Great work so far! I really like the new layout and looks much cleaner. > > > > I looked over a few pages that I knew and use more often: > > > > Conversion > > * Nested pages like (Solr JDBC - *) don't show as nested under the > > navigation sidebar > > This is the next problem I'm going to look at. We're using a theme for > Jekyll that I found, and that theme only supports 2 levels (top and > one more) so the existing hierarchy had to be flattened out. I'm going > to see if we can get 3 or 4 levels to replicate our current hierarchy. > > > * Some images aren't being rendered > > ** > > http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/solr-jdbc-dbvisualizer.html > > ** > > http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/solr-jdbc-squirrel-sql.html > > ** > > http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/solr-jdbc-apache-zeppelin.html > > Hmm. Will need to look into that. I filed an issue in the GH project > to track it: https://github.com/ctargett/refguide-asciidoc-poc/issues/20 > > > * Some links as code seem to be broken (`SolrClient` and > `HttpSolrClient`) > > ** http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/using-solrj.html > > Another good catch. These use Confluence's funky system for javadoc > links. I filed another issue: > https://github.com/ctargett/refguide-asciidoc-poc/issues/21 > > > * Collections API - > > http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/collections-api.html > > ** Shouldn't have a "On this Page" tree > > ** API entry point section is missing new lines > > We'll have to fix the new lines manually - it isn't a proper list in > Confluence, so isn't getting exported with proper HTML tags, so > conversion doesn't know what to do with them. > > I don't understand why it shouldn't have an "On this Page" tree, though? > > > Usability > > * Logo link in top left goes to index.html and not > > apache-solr-reference-guide.html > > I'll fix that. https://github.com/ctargett/refguide-asciidoc-poc/issues/22 > > > * Is the search box supposed to work? > > Yes, not sure why it's not. I will review how it works and fix it. > https://github.com/ctargett/refguide-asciidoc-poc/issues/24 > > > * Bottom right says company logo with a broken image > > I will fix that too. https://github.com/ctargett/ > refguide-asciidoc-poc/issues/23 > > > * Each section has its name in the drop down (About This Guide -> About > This > > Guide; Getting Started -> Getting Started). Does it make sense to remove > > this redundancy? > > Yes, this is a side effect of that particular theme. I've got an issue > already for this that explains why it happens like that: > https://github.com/ctargett/refguide-asciidoc-poc/issues/ > 7#issuecomment-248391179 > > > * When you go to a page from the navigation sidebar, the navigation > sidebar > > doesn't stay open to where you started from > > > > It's supposed to: https://github.com/ctargett/ > refguide-asciidoc-poc/issues/11 > > > Broken on Confluence (highlighted during conversion) > > * http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/using-solrj.html > > ** Asynchronous calls -> output - XML is highlighted as JSON > > * SQL is syntax highlighted as Java > > ** > > http://home.apache.org/~ctargett/RefGuidePOC/jekyll- > full/parallel-sql-interface.html > > > > We're converting what Confluence tells us - defaulting to Java if it > is unknown. In your first case, if we fix it in Confluence, that > should fix it for conversion. In the second case, however, Confluence > doesn't have an "SQL" syntax highlighter, but Asciidoctor does, so > we'll have to fix that as we find it when we review the pages for > conversion. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
