[
https://issues.apache.org/jira/browse/SOLR-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-9551:
--------------------------------------
Attachment: SOLR-9551.patch
Hi Jonny, we talked offline. Please find attached an alternative patch:
* the protected JSONWriter.wrapperFunction remains non-final
* no unnecessary JSONResponseWriter.write change
* the JSON_NL_* constants remain in JSONWriter but now have package visibility
e.g. for use by the newly added JSONWriterTest.testConstantsUnchanged method
and also for use by the upcoming SOLR-9442 change
> Add constructor to JSONWriter which takes wrapperFunction and namedListStyle
> ----------------------------------------------------------------------------
>
> Key: SOLR-9551
> URL: https://issues.apache.org/jira/browse/SOLR-9551
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Jonny Marks
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9551.patch, SOLR-9551.patch
>
>
> Currently JSONWriter's constructor extracts the wrapperFunction and
> namedListStyle from the request.
> This patch adds a new constructor where these are passed in from
> JSONResponseWriter. This will allow us to decide in JSONResponseWriter which
> writer to construct based on the named list style.
> There is precedent here - GeoJSONResponseWriter extracts geofield from the
> request and passes it to GeoJSONWriter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
