[
https://issues.apache.org/jira/browse/SOLR-9310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430880#comment-15430880
]
Yonik Seeley edited comment on SOLR-9310 at 8/22/16 2:44 PM:
-------------------------------------------------------------
Reopening... the cache that was added in SolrIndexSearcher is not thread safe
and is checked outside synchronization.
Also, about this comment:
{code}
// TODO what happens if updates came out of order, would cached fingerprint
still be valid?
// May be caching fingerprint may lead more problems
{code}
The index fingerprint only depends on what documents are in the index, not on
their order in the index. And since the cache is on SolrIndexSearcher (which
has a static view of the index), it will be impossible for fingerprint to
change for a given max version. The comment should probably just be removed to
avoid confusion.
In changes on UpdateLog:
{code}
+ if(ptr.version > maxVersion) continue;
{code}
versions can be negative for deletes, so we should really be checking against
the absolute value of ptr.version
was (Author: [email protected]):
Reopening... the cache that was added in SolrIndexSearcher is not thread safe
and is checked outside synchronization.
Also, about this comment:
{code}
// TODO what happens if updates came out of order, would cached fingerprint
still be valid?
// May be caching fingerprint may lead more problems
{code}
The index fingerprint only depends on what documents are in the index, not on
their order in the index. And since the cache is on SolrIndexSearcher (which
has a static view of the index), it will be impossible for fingerprint to
change for a given max version. The comment should probably just be removed to
avoid confusion.
> PeerSync fails on a node restart due to IndexFingerPrint mismatch
> -----------------------------------------------------------------
>
> Key: SOLR-9310
> URL: https://issues.apache.org/jira/browse/SOLR-9310
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Pushkar Raste
> Assignee: Noble Paul
> Fix For: trunk, 6.3
>
> Attachments: PeerSync_3Node_Setup.jpg, PeerSync_Experiment.patch,
> SOLR-9310.patch, SOLR-9310.patch, SOLR-9310.patch, SOLR-9310.patch,
> SOLR-9310.patch, SOLR-9310_3ReplicaTest.patch, SOLR-9310_final.patch
>
>
> I found that Peer Sync fails if a node restarts and documents were indexed
> while node was down. IndexFingerPrint check fails after recovering node
> applies updates.
> This happens only when node restarts and not if node just misses updates due
> reason other than it being down.
> Please check attached patch for the test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
