GitHub user kelaban opened a pull request:

    https://github.com/apache/lucene-solr/pull/50

    SOLR-9280 - make nodeName a configurable parameter in solr.xml

    This patch makes live nodeName configurable via solr.xml by setting
    ```xml
    <solr>
        <solrcloud>
            <str name="nodeName">${solr.nodeName:}</str>
        </solrcloud> 
    </solr>
    ```
    
    To test, I randomly set nodeName in `AbstractFullDistribZkTestBase` for 
complete coverage.
    
    I've gotten all tests to pass both when ALWAYS using a random nodeName and 
with it being set randomly. However during one particular run I got a test 
failure for the following:
    `ant test  -Dtestcase=TestReqParamsAPI -Dtests.method=test 
-Dtests.seed=391BC4715DE8C2FE -Dtests.slow=true -Dtests.locale=pl-PL 
-Dtests.timezone=Asia/Chungking -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8` but am unable to reproduce the issue in eclipse 
and at this time am not sure if its related
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kelaban/lucene-solr jira/master/SOLR-9280

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #50
    
----
commit b1de1f9ef97a5957747f7fcb9ac9e7ce4acfac84
Author: Keith Laban <[email protected]>
Date:   2016-06-30T15:12:16Z

    SOLR-9280 - make nodeName a configurable parameter in solr.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to