[ 
https://issues.apache.org/jira/browse/LUCENE-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349595#comment-15349595
 ] 

Grant Ingersoll commented on LUCENE-7354:
-----------------------------------------

This is also a Solr issue.  I'm not a big fan of the API for the like call in 
this particular case: 
{{code}}public Query like(Map<String, Collection<Object>> filteredDocument) 
throws IOException {{code}} is just asking for trouble, even if that saves a 
few operations in Solr.  

My proposal:
# Change that signature, which is only used by Solr in CloudMLTQParser, to take 
Map<String, Collection<String>>, thus forcing some type safety
# Fix the retrieveTerms to check the fields line up.  
# Write some tests for the code path in question.

> MoreLikeThis incorrectly does toString on Field object
> ------------------------------------------------------
>
>                 Key: LUCENE-7354
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7354
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 6.0.1, 5.5.1, master (7.0)
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>
> In MoreLikeThis.java, circa line 763, when calling addTermFrequencies on a 
> Field object, we are incorrectly calling toString on the Field object, which 
> puts the Field attributes (indexed, stored, et. al) into the String that is 
> returned.
> I'll put up a patch/fix shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to