[ 
https://issues.apache.org/jira/browse/LUCENE-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013747#comment-13013747
 ] 

Yonik Seeley commented on LUCENE-3003:
--------------------------------------

bq. The first-pass that allocates lots of tiny byte[] looks like it could be 
inefficient. Maybe we could use the byte slices from the indexer for this...

It is inefficient - but I never saw a way around it since the lists are all 
being built in parallel (due to the fact that we are uninverting).


Another small & easy optimization I hadn't gotten around to yet was to lower 
the indexIntervalBits and make it configurable.  Another small optimization 
would be to store an array of offsets to length-prefixed byte arrays, rather 
than a BytesRef[].  At least the values are already in packed byte arrays via 
PagedBytes.


I'd also love to hear others thoughts on this memory optimization for many 
small byte arrays:
{code}
              // We avoid a doubling strategy to lower memory usage.
              // this faceting method isn't for docs with many terms.
              // In hotspot, objects have 2 words of overhead, then fields, 
rounded up to a 64-bit boundary.
              // TODO: figure out what array lengths we can round up to w/o 
actually using more memory
              // (how much space does a byte[] take up?  Is data preceded by a 
32 bit length only?
              // It should be safe to round up to the nearest 32 bits in any 
case.
              int newLen = (newend + 3) & 0xfffffffc;  // 4 byte alignment
{code}

> Move UnInvertedField into Lucene core
> -------------------------------------
>
>                 Key: LUCENE-3003
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3003
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3003.patch, LUCENE-3003.patch
>
>
> Solr's UnInvertedField lets you quickly lookup all terms ords for a
> given doc/field.
> Like, FieldCache, it inverts the index to produce this, and creates a
> RAM-resident data structure holding the bits; but, unlike FieldCache,
> it can handle multiple values per doc, and, it does not hold the term
> bytes in RAM.  Rather, it holds only term ords, and then uses
> TermsEnum to resolve ord -> term.
> This is great eg for faceting, where you want to use int ords for all
> of your counting, and then only at the end you need to resolve the
> "top N" ords to their text.
> I think this is a useful core functionality, and we should move most
> of it into Lucene's core.  It's a good complement to FieldCache.  For
> this first baby step, I just move it into core and refactor Solr's
> usage of it.
> After this, as separate issues, I think there are some things we could
> explore/improve:
>   * The first-pass that allocates lots of tiny byte[] looks like it
>     could be inefficient.  Maybe we could use the byte slices from the
>     indexer for this...
>   * We can improve the RAM efficiency of the TermIndex: if the codec
>     supports ords, and we are operating on one segment, we should just
>     use it.  If not, we can use a more RAM-efficient data structure,
>     eg an FST mapping to the ord.
>   * We may be able to improve on the main byte[] representation by
>     using packed ints instead of delta-vInt?
>   * Eventually we should fold this ability into docvalues, ie we'd
>     write the byte[] image at indexing time, and then loading would be
>     fast, instead of uninverting

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to