[ 
https://issues.apache.org/jira/browse/SOLR-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012787#comment-13012787
 ] 

Hoss Man commented on SOLR-2338:
--------------------------------

skimming the patch, the one thing i'm not clear on is what happens when someone 
who has been using a custom similarity (or similarity factory) in Solr 1.4 or 
3.1 will be affected on upgrading.

the patch seems to remove the code that allows for a (global) {{<similarity/>}} 
element in schema.xml (replacing it with a check for {{<similarityProvider/>}}

i'm not clear on whether there is really a compelling reason for this (if there 
is we should have a nice fat warning in the upgrading section of CHANGES.txt) 
or if we could still continue to respect the {{<similarity/>}} syntax ... it 
seems like that one tag could be used to refrence (by classname) a global 
SimilarityProviderFactory, or a default Similarity instance or default.

even if there's a really good reason not to keep using what we might find in 
{{<similarity/>}}, we should check for it and log a nice fat error message 
saying it's being ignored.

> improved per-field similarity integration into schema.xml
> ---------------------------------------------------------
>
>                 Key: SOLR-2338
>                 URL: https://issues.apache.org/jira/browse/SOLR-2338
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>         Attachments: SOLR-2338.patch, SOLR-2338.patch
>
>
> Currently since LUCENE-2236, we can enable Similarity per-field, but in 
> schema.xml there is only a 'global' factory
> for the SimilarityProvider.
> In my opinion this is too low-level because to customize Similarity on a 
> per-field basis, you have to set your own
> CustomSimilarityProvider with <similarity class=.../> and manage the 
> per-field mapping yourself in java code.
> Instead I think it would be better if you just specify the Similarity in the 
> FieldType, like after <analyzer>.
> As far as the example, one idea from LUCENE-1360 was to make a "short_text" 
> or "metadata_text" used by the
> various metadata fields in the example that has better norm quantization for 
> its shortness...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to