I think taking them out is ok or log.fine
On Tue, Mar 29, 2011 at 8:09 PM, Chris Hostetter <[email protected]> wrote: > > > These messages are now logged on every request, even if no transformer or > globs are used in the fl. > > seems like this should be a DEBUG message at best? > > if folks really think it's important to log this on every request, then > shouldn't these three key=val pairs just be factored into the main request > log message SolrCore does? (by adding them to > SolrQueryResponse.getToLog()) > > ? > > > : Date: Sat, 26 Mar 2011 00:44:10 -0000 > : From: [email protected] > : Reply-To: [email protected] > : To: [email protected] > : Subject: svn commit: r1085618 - > : /lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java > : > : Author: ryan > : Date: Sat Mar 26 00:44:10 2011 > : New Revision: 1085618 > : > : URL: http://svn.apache.org/viewvc?rev=1085618&view=rev > : Log: > : remove nocommit from log message > : > : Modified: > : lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java > : > : Modified: > lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java > : URL: > http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java?rev=1085618&r1=1085617&r2=1085618&view=diff > : > ============================================================================== > : --- lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java > (original) > : +++ lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java > Sat Mar 26 00:44:10 2011 > : @@ -97,12 +97,12 @@ public class ReturnFields > : parseFieldList( new String[]{fl}, req); > : } > : } > : - req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t > transformer="+transformer); // nocommit > : + req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t > transformer="+transformer); > : } > : > : public ReturnFields(String[] fl, SolrQueryRequest req) { > : parseFieldList(fl, req); > : - req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t > transformer="+transformer); // nocommit > : + req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t > transformer="+transformer); > : } > : > : private void parseFieldList(String[] fl, SolrQueryRequest req) { > : > : > : > > -Hoss > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
