[
https://issues.apache.org/jira/browse/LUCENE-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229955#comment-15229955
]
Michael McCandless commented on LUCENE-7168:
--------------------------------------------
bq. Michael McCandless: I realized suddenly how to do this properly.
I like this approach, but, I thought this is what we are doing already!
I.e., BKD fundamentally already operates in this quantized (small cube) space,
since it's only ever given quantized points, and it splits at the quantized
points.
Then, in {{PointInShapeIntersectVisitor.compare}} we do this:
{noformat}
double xMin =
decodeValueMin(NumericUtils.sortableBytesToInt(minPackedValue, 0));
double xMax =
decodeValueMax(NumericUtils.sortableBytesToInt(maxPackedValue, 0));
double yMin =
decodeValueMin(NumericUtils.sortableBytesToInt(minPackedValue, 1 *
Integer.BYTES));
double yMax =
decodeValueMax(NumericUtils.sortableBytesToInt(maxPackedValue, 1 *
Integer.BYTES));
double zMin =
decodeValueMin(NumericUtils.sortableBytesToInt(minPackedValue, 2 *
Integer.BYTES));
double zMax =
decodeValueMax(NumericUtils.sortableBytesToInt(maxPackedValue, 2 *
Integer.BYTES));
GeoArea xyzSolid = GeoAreaFactory.makeGeoArea(PlanetModel.WGS84, xMin,
xMax, yMin, yMax, zMin, zMax);
{noformat}
I.e, that {{xyzSolid}} should in fact already be spanning the full little-cube
space that this BKD cell covers? We then go on and relate that {{xyzSolid}} to
the query shape.
> Remove geo3d test leniency
> --------------------------
>
> Key: LUCENE-7168
> URL: https://issues.apache.org/jira/browse/LUCENE-7168
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Fix For: master, 6.1
>
> Attachments: LUCENE-7168.patch, LUCENE-7168.patch, LUCENE-7168.patch,
> LUCENE-7168.patch, LUCENE-7168.patch
>
>
> Today the test hides possible failures by leniently handling quantization
> issues.
> We should fix it to do what geo2d tests now do: pre-quantized indexed points,
> but don't quantize query shapes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
