[ 
https://issues.apache.org/jira/browse/LUCENE-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-7170:
--------------------------------
    Attachment: LUCENE-7170.patch

Here is a patch. Basically it just moves the file and removes the sandbox/ dep 
on spatial/
{noformat}
        modified:   dev-tools/maven/lucene/sandbox/pom.xml.template
        modified:   lucene/sandbox/build.xml
        modified:   
lucene/sandbox/src/test/org/apache/lucene/search/TestLatLonPointQueries.java
        modified:   
lucene/spatial/src/test/org/apache/lucene/spatial/geopoint/search/TestGeoPointQuery.java
        modified:   
lucene/spatial/src/test/org/apache/lucene/spatial/geopoint/search/TestLegacyGeoPointQuery.java
        renamed:    
lucene/spatial/src/test/org/apache/lucene/spatial/util/BaseGeoPointTestCase.java
 -> 
lucene/test-framework/src/java/org/apache/lucene/geo/BaseGeoPointTestCase.java
{noformat}

> move BaseGeoPointTestCase to test-framework
> -------------------------------------------
>
>                 Key: LUCENE-7170
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7170
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-7170.patch
>
>
> This abstract test class has hooks for basic operations:
> {code}
>   protected abstract void addPointToDoc(String field, Document doc, double 
> lat, double lon);
>   protected abstract Query newRectQuery(String field, double minLat, double 
> maxLat, double minLon, double maxLon);
>   protected abstract Query newDistanceQuery(String field, double centerLat, 
> double centerLon, double radiusMeters);
>   protected abstract Query newPolygonQuery(String field, Polygon... polygon);
> {code}
> and hooks for quantization (quantizeLat/quantizeLon) so it can demand exact 
> answers.
> We currently have 3 subclasses, one is in the sandbox. I don't think the 
> sandbox/ should have to depend on spatial/ just for this base test class, and 
> having it in test-framework is a better place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to