[
https://issues.apache.org/jira/browse/LUCENE-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221563#comment-15221563
]
Karl Wright edited comment on LUCENE-7157 at 4/1/16 11:39 AM:
--------------------------------------------------------------
I have an implementation of this; adding tests because it is fairly complex
math and needs thorough testing.
[~rcmuir]: The explanation you gave earlier that was effectively that the sense
of polygon direction didn't matter in 2D for the ways you were using it was
tantamount to saying that an area that was on one side of a polygon edge was
effectively equivalent to its complement on the other side of the polygon edge.
On the face of it, that cannot be true, except maybe in a 2D world where
objects are always considered less in extent than 180 degrees, and it requires
special casing to cross date lines etc. So it is possible you have a bug you
are unaware of.
I also looked at your Polygon class and I am sure you are aware that it
contains a significant amount of 2D implementation detail. I cannot use that
for Geo3D. I had expected it to contain only a specification for a polygon and
nested holes. Not sure if you wanted to do anything to separate the concerns
but it seems like a class used at the API level should not have implementation
detail in it.
was (Author: [email protected]):
I have an implementation of this; adding tests because it is fairly complex
math and needs thorough testing.
[~rcmuir]: The explanation you gave earlier that was effectively that the sense
of polygon direction didn't matter in 2D for the ways you were using it was
tantamount to saying that an area that was on one side of a polygon edge was
effectively equivalent to its complement on the other side of the polygon edge.
On the face of it, that cannot be true, except maybe in a 2D world where
objects are always considered less in extent than 180 degrees, and it requires
special casing to cross date lines etc. So it is possible you have a bug you
are unaware of.
I also looked at your Polygon class and I am sure you are aware that it
contains a significant amount if 2D implementation detail. I cannot use that
for Geo3D. I had expected it to contain only a specification for a polygon and
nested holes. Not sure if you wanted to do anything to separate the concerns
but it seems like a class used at the API level should not have implementation
detail in it.
> Geo3DPoint implementation should pay attention to the ordering of lat/lon
> points
> --------------------------------------------------------------------------------
>
> Key: LUCENE-7157
> URL: https://issues.apache.org/jira/browse/LUCENE-7157
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Karl Wright
>
> The LatLonPoint API implementation pays attention to the order of the points;
> "clockwise" means one side of the polygon boundary, and "counterclockwise"
> means the complement. We need to use that in Geo3DPoint and convert into
> whatever the underlying GeoPolygonFactory method requires.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
