Ok; I have this simple change in my patch (and branch) for SOLR-5750. It seems like this bug is not as bad as it may appear because normal collection creation takes a code path that expressly states the state format to be 2, whereas for this new collection restoration feature a different path is taken that doesn't set it. If people think this needs its own issue then I'll file one and commit it.
On Fri, Mar 18, 2016 at 7:20 PM Mark Miller <[email protected]> wrote: > We certainly discussed making it two and there was consensus, and I would > have sworn someone did, but perhaps no one ever did. > > - Mark > > On Fri, Mar 18, 2016 at 7:09 PM Scott Blum <[email protected]> wrote: > >> That seems really bad, the default should be 2. >> >> On Fri, Mar 18, 2016 at 3:28 PM, David Smiley <[email protected]> >> wrote: >> >>> I noticed ClusterStateMutator.createCollection defaults the state format >>> to 1 if it's not explicitly set -- line 104. Shouldn't it be 2? While >>> working on a test for collection restore from a backup (SOLR-5750) I see >>> the restored collection ends up being in the old (1) state format because >>> of this. >>> >>> I'll file an issue unless someone can confirm it's supposed to be this >>> way. >>> -- >>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: >>> http://www.solrenterprisesearchserver.com >>> >> >> -- > - Mark > about.me/markrmiller > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
