[ 
https://issues.apache.org/jira/browse/SOLR-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180036#comment-15180036
 ] 

Shalin Shekhar Mangar commented on SOLR-8745:
---------------------------------------------

ZkStateReader.forceUpdateCollection has the following:
{code}
else if (ref.isLazilyLoaded()) {
        if (ref.get() != null) {
          return;
        }
        // Edge case: if there's no external collection, try refreshing legacy 
cluster state in case it's there.
        refreshLegacyClusterState(null);
      }
{code}

Scott, can you please explain when this edge case may be triggered?

> Deprecate ZkStateReader.updateClusterState(), remove uses
> ---------------------------------------------------------
>
>                 Key: SOLR-8745
>                 URL: https://issues.apache.org/jira/browse/SOLR-8745
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 5.4.1
>            Reporter: Scott Blum
>            Assignee: Shalin Shekhar Mangar
>              Labels: patch, performance, solrcloud
>         Attachments: SOLR-8745.patch
>
>
> Forcing a full ZK cluster state update creates a lot of unnecessary work and 
> load at scale.  We need to deprecate and remove existing callers.
> - The one at the start of ClusterStateUpdater thread is fine, it's a one-time 
> thing.
> - The one in OverseerCollectionMessageHandler is getting removed in SOLR-8722
> - The rest of them can be replaced with a version that only updates a single 
> collection; not everything!
> Patch will be forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to