[
https://issues.apache.org/jira/browse/LUCENE-7059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175930#comment-15175930
]
ASF subversion and git services commented on LUCENE-7059:
---------------------------------------------------------
Commit e3198cac549b7297d4842cb99f5d9eef9b7dc6fe in lucene-solr's branch
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e3198ca ]
LUCENE-7059: always visit 1D points in sorted order; fix tie-break but in
BKDWriter; fix BKDWriter to pass on maxMBSortInHeap to the OfflineSorter too
> Verify that 1D point values are visited in order
> ------------------------------------------------
>
> Key: LUCENE-7059
> URL: https://issues.apache.org/jira/browse/LUCENE-7059
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Blocker
> Fix For: master, 6.0
>
> Attachments: LUCENE-7059.patch
>
>
> The new PointInSetQuery (LUCENE-7048) hit a tricky test failure
> (https://builds.apache.org/job/Lucene-Solr-Tests-trunk-Java8/871/)
> where point values were sometimes not visited in order like it
> expected.
> I pushed a hack to fix the query, but I think we should do a better
> fix, here, making the "values in order in the 1D case" part of the
> API, fixing CheckIndex, AssertingPointFormat to verify this, and
> removing the buggy MultiPointValues.
> I also found a possibly serious bug in BKDWriter, where it was doing
> {{writeInt/writeLong}} to its offline files, but then reading with
> {{readVInt/readVLong}}! It's hard to provoke, though: it only strikes
> in the tie-break case (same values across docs), and even then only if
> the {{IntroSorter}} does a non-stable sort. I made a failing test
> case and fixed that bug, and also removed the unnecessary ord tie
> breaking from BKDWriter's comparator.
> Finally, I saw {{BKDWriter}} was failing to pass on its
> {{maxMBSortInHeap}} down to {{OfflineSorter}}, and fixed that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
