FYI,
this is the bug: <https://bugs.openjdk.java.net/browse/JDK-8051958> https://bugs.openjdk.java.net/browse/JDK-8051958 This happened because I converted the UTF-16-Comparator to a lambda while moving it away from Core’s BytesRef to TSTLookup. Anyways, the code now reads much better and it is similar to other comparators (like the original one in BytesRef). Uwe ----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen <http://www.thetaphi.de/> http://www.thetaphi.de eMail: [email protected] From: Alan Woodward [mailto:[email protected]] Sent: Tuesday, March 01, 2016 7:17 PM To: [email protected] Subject: Re: Master branch and java version Yup, that fixes it. Thanks Uwe! Although perhaps we should be forcing everybody to upgrade to a non-buggy JVM anyway :-) On 1 Mar 2016, at 17:38, Uwe Schindler wrote: Hi, I committed the following fix, simplifying the code to a one-liner: https://goo.gl/Vv8PXp This should work around the 8u25 bug. Can anybody verify this? Uwe ----- Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen <http://www.thetaphi.de/> http://www.thetaphi.de eMail: [email protected] <mailto:[email protected]> From: Erik Hatcher [ <mailto:[email protected]> mailto:[email protected]] Sent: Tuesday, March 01, 2016 5:48 PM To: <mailto:[email protected]> [email protected] Subject: Re: Master branch and java version And ditto, thanks Alan. I hit this issue myself yesterday morning and had just finished working through upgrading my JDK and getting master compiling again when I saw your message. — Erik Hatcher, Senior Solutions Architect http://www.lucidworks.com On Mar 1, 2016, at 9:52 AM, [email protected] <mailto:[email protected]> wrote: Me too; minutes after your notice Alan. Thanks for the FYI. On Tue, Mar 1, 2016 at 5:18 AM Varun Thacker <[email protected] <mailto:[email protected]> > wrote: I also ran into the same problem. I was using 1.8.0_31 . Upgrading worked though. On Tue, Mar 1, 2016 at 3:19 AM, Alan Woodward <[email protected] <mailto:[email protected]> > wrote: common.compile-core: [javac] Compiling 1 source file to /Users/woody/asf/lucene-solr-trunk/lucene/build/suggest/classes/java [javac] /Users/woody/asf/lucene-solr-trunk/lucene/suggest/src/java/org/apache/lucene/search/suggest/tst/TSTLookup.java:79: error: cannot assign a value to final variable aStop [javac] aStop = aUpto + a.length; [javac] ^ [javac] /Users/woody/asf/lucene-solr-trunk/lucene/suggest/src/java/org/apache/lucene/search/suggest/tst/TSTLookup.java:81: error: cannot assign a value to final variable aStop [javac] aStop = aUpto + b.length; [javac] ^ [javac] 2 errors Compiles under 1.8.0_74, gives this error for 1.8.0_25 On 29 Feb 2016, at 21:38, Uwe Schindler wrote: Can you post the error? I touched that code yesterday. Maybe I broke that. It would still be good to fix this. Uwe Am 29. Februar 2016 21:08:50 MEZ, schrieb Alan Woodward <[email protected] <mailto:[email protected]> >: Just in case anybody else out there runs into this, I was having problems compiling master earlier using Java 1.8.0_25, due to the compiler not liking an immediate assignment to a final variable in TSTLookup.java. Upgrading to 1.8.0_74 made the problem go away. -- Uwe Schindler H.-H.-Meier-Allee 63, 28213 Bremen http://www.thetaphi.de <http://www.thetaphi.de/> -- Regards, Varun Thacker -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com <http://www.solrenterprisesearchserver.com/>
