[
https://issues.apache.org/jira/browse/SOLR-8724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169717#comment-15169717
]
Mark Miller commented on SOLR-8724:
-----------------------------------
+1, LGTM.
bq. If it weren't for that last item, I'd advocate for getting rid of this
patched parseProperties() and directly calling the superclass version, catching
the ".../myid file is missing" IllegalArgumentException, and handling setting
the server id in the catch block.
Might not be a bad improvement - not ideal to have the MDC call, but also
probably not very problematic.
> Upgrade Zookeeper to 3.4.8
> --------------------------
>
> Key: SOLR-8724
> URL: https://issues.apache.org/jira/browse/SOLR-8724
> Project: Solr
> Issue Type: Bug
> Reporter: Steve Rowe
> Fix For: master
>
> Attachments: SOLR-8724.patch, SOLR-8724.patch
>
>
> Zookeeper 3.4.8 was released a few days ago - we should upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
