[
https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140753#comment-15140753
]
Shai Erera commented on SOLR-8621:
----------------------------------
Good catch, I just blindly moved that 'mergeFactor' in :). I'll remove it. I'd
like to keep the example though, since it's consistent with the rest of the
commented out examples.
About {{SortingMergePolicyFactory}} and {{IndexSchema}}, I see that
{{SortSpecParsing}} uses the provided schema only to validate that the field
exists in the schema. If we want to keep that validity check, then let's
continue with your proposal of passing {{IndexSchema}} to the factory's ctor.
About this parsing logic, it also relies on request params, so perhaps factor
out the parsing logic to a utility that you can use? That utility can then also
validate that the sort field exists in the schema. I didn't review that method
fully, but I hope it's doable.
> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
> Key: SOLR-8621
> URL: https://issues.apache.org/jira/browse/SOLR-8621
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Blocker
> Fix For: 5.5, master
>
> Attachments: SOLR-8621-example_contrib_configs.patch,
> SOLR-8621.patch, explicit-merge-auto-set.patch
>
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge
> policies can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support
> +work-in-progress summary:+
> * main code changes have been committed to master and branch_5x
> * {color:red}further small code change required:{color} MergePolicyFactory
> constructor or MergePolicyFactory.getMergePolicy method to take IndexSchema
> argument (e.g. for use by SortingMergePolicyFactory being added under related
> SOLR-5730)
> * Solr Reference Guide changes (directly in Confluence?)
> * changes to remaining solrconfig.xml
> ** solr/core/src/test-files/solr/collection1/conf - Christine
> ** solr/contrib
> ** solr/example
> +open question:+
> * Do we want to error if luceneMatchVersion >= 5.5 and deprecated
> mergePolicy/mergeFactor/maxMergeDocs are used? See [~hossman]'s comment on
> Feb 1st. The code as-is permits mergePolicy irrespective of
> luceneMatchVersion, I think.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
