[
https://issues.apache.org/jira/browse/SOLR-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069016#comment-15069016
]
Mark Miller edited comment on SOLR-8453 at 12/23/15 1:47 AM:
-------------------------------------------------------------
bq. I'll run the tests in a loop with this patch to see if I can reproduce the
failures.
I'm still looping more recent versions. If you get a chance, update to the most
recent patch. It has some changes to how our clients handle cleanup under
failures. I think we overdo method.abort and I think it messes up connection
reuse. On a clean server->client exception, we should simply make sure the
response entity content is fully consumed and closed like a normal request.
was (Author: [email protected]):
bq. I'll run the tests in a loop with this patch to see if I can reproduce the
failures.
I'm still looping more recent versions. If you get a chance, update to the most
recent patch. It has some chances to how our clients handle cleanup under
failures. I think we overdo method.abort and I think it messes up connection
reuse.
> Local exceptions in DistributedUpdateProcessor should not cut off an ongoing
> request.
> -------------------------------------------------------------------------------------
>
> Key: SOLR-8453
> URL: https://issues.apache.org/jira/browse/SOLR-8453
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch,
> SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch, SOLR-8453.patch
>
>
> The basic problem is that when we are streaming in updates via a client, an
> update can fail in a way that further updates in the request will not be
> processed, but not in a way that causes the client to stop and finish up the
> request before the server does something else with that connection.
> This seems to mean that even after the server stops processing the request,
> the concurrent update client is still in the process of sending the request.
> It seems previously, Jetty would not go after the connection very quickly
> after the server processing thread was stopped via exception, and the client
> (usually?) had time to clean up properly. But after the Jetty upgrade from
> 9.2 to 9.3, Jetty closes the connection on the server sooner than previous
> versions (?), and the client does not end up getting notified of the original
> exception at all and instead hits a connection reset exception. The result
> was random fails due to connection reset throughout our tests and one
> particular test failing consistently. Even before this update, it does not
> seem like we are acting in a safe or 'behaved' manner, but our version of
> Jetty was relaxed enough (or a bug was fixed?) for our tests to work out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
