Hi Upayavira,

The svn revision in the URL is wrong. It should be 1718046 but it is
178046 which makes the smoke tester fail with the following message:

RuntimeError: JAR file
"/tmp/smoke_lucene_5.4.0_178046_1/unpack/lucene-5.4.0/analysis/common/lucene-analyzers-common-5.4.0.jar"
is missing "Implementation-Version: 5.4.0 178046 " inside its
META-INF/MANIFEST.MF (wrong svn revision?)

I think you may need to generate a new RC. But perhaps an svn move to
a path with the right revision number may also suffice?

On Mon, Dec 7, 2015 at 9:12 AM, Shalin Shekhar Mangar
<[email protected]> wrote:
> Thanks Upayavira. I guess Apache has started redirecting http traffic
> to https recently on dist.apache.org which must have broken this
> script. I am able to run smoke tester after applying your patch.
>
> On Mon, Dec 7, 2015 at 2:08 AM, Upayavira <[email protected]> wrote:
>> The getHREFs() method is taking in an HTTPS URL, but failing to preserve
>> the protocol, resulting in an HTTP call that the server naturally
>> bounces to HTTPS. Unfortunately, the next loop round also forgets the
>> HTTPS, and hence we're stuck in an endless loop. Below is a patch that
>> fixes this issue. I'd rather someone with more knowledge of this script
>> confirm my suspicion and apply the patch for us all to use, as I cannot
>> see how this ever worked.
>>
>> I personally ran the smoke test on my local copy, so did not hit this
>> HTTP/HTTPS code. I'm running the HTTP version now, and will check on it
>> in the morning.
>>
>> Index: dev-tools/scripts/smokeTestRelease.py
>> ===================================================================
>> --- dev-tools/scripts/smokeTestRelease.py       (revision 1718046)
>> +++ dev-tools/scripts/smokeTestRelease.py       (working copy)
>> @@ -84,7 +84,12 @@
>>    # Deref any redirects
>>    while True:
>>      url = urllib.parse.urlparse(urlString)
>> -    h = http.client.HTTPConnection(url.netloc)
>> +    if url.scheme == "http":
>> +      h = http.client.HTTPConnection(url.netloc)
>> +    elif url.scheme == "https":
>> +      h = http.client.HTTPSConnection(url.netloc)
>> +    else:
>> +      raise RuntimeError("Unknown protocol: %s" % url.scheme)
>>      h.request('GET', url.path)
>>      r = h.getresponse()
>>      newLoc = r.getheader('location')
>>
>> Upayavira
>>
>> On Sun, Dec 6, 2015, at 06:26 PM, Noble Paul wrote:
>>> Same here.
>>>
>>> On Sun, Dec 6, 2015 at 2:36 PM, Shalin Shekhar Mangar
>>> <[email protected]> wrote:
>>> > Is anyone able to run the smoke tester on this RC? It just hangs for a
>>> > long time on "loading release URL" for me.
>>> >
>>> > python3 -u dev-tools/scripts/smokeTestRelease.py --tmp-dir
>>> > ../smoke-5.4 --revision 178046 --version 5.4.0 --test-java8
>>> > ~/programs/jdk8
>>> > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.4.0-RC1-rev178046/
>>> > Java 1.7 JAVA_HOME=/home/shalin/programs/jdk7
>>> > Java 1.8 JAVA_HOME=/home/shalin/programs/jdk8
>>> > NOTE: output encoding is UTF-8
>>> >
>>> > Load release URL
>>> > "https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.4.0-RC1-rev178046/";...
>>> >
>>> > I did a strace and found that the server is returning a HTTP 301 moved
>>> > permanently response to the http request.
>>> >
>>> > On Sat, Dec 5, 2015 at 4:28 PM, Upayavira <[email protected]> wrote:
>>> >> Please vote for the RC1 release candidate for Lucene/Solr 5.4.0
>>> >>
>>> >> The artifacts can be downloaded from:
>>> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.4.0-RC1-rev178046
>>> >>
>>> >> You can run the smoke tester directly with this command:
>>> >> python3 -u dev-tools/scripts/smokeTestRelease.py
>>> >> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-5.4.0-RC1-rev178046
>>> >>
>>> >> I will let this vote run until midnight (GMT) on Wednesday 9 December.
>>> >>
>>> >> Please cast your votes! (and let me know, politely :-) if I missed
>>> >> anything)
>>> >>
>>> >> Upayavira
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: [email protected]
>>> >> For additional commands, e-mail: [email protected]
>>> >>
>>> >
>>> >
>>> >
>>> > --
>>> > Regards,
>>> > Shalin Shekhar Mangar.
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: [email protected]
>>> > For additional commands, e-mail: [email protected]
>>> >
>>>
>>>
>>>
>>> --
>>> -----------------------------------------------------
>>> Noble Paul
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>
>
>
> --
> Regards,
> Shalin Shekhar Mangar.



-- 
Regards,
Shalin Shekhar Mangar.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to