[ 
https://issues.apache.org/jira/browse/SOLR-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026549#comment-15026549
 ] 

Christine Poerschke commented on SOLR-8338:
-------------------------------------------

Thanks for the review Ishan. I wasn't aware of 
{{SolrTestCaseJ4.DEFAULT_TEST_CORENAME}} until now. How about adding a 
{{SolrTestCaseJ4.DEFAULT_TEST_COLLECTION_NAME}} and then using that instead of 
the current {{"collection1"}}?

{code}
public abstract class SolrTestCaseJ4 extends LuceneTestCase {
 
-  public static final String DEFAULT_TEST_CORENAME = "collection1";
+  public static final String DEFAULT_TEST_COLLECTION_NAME = "collection1";
+  public static final String DEFAULT_TEST_CORENAME = 
DEFAULT_TEST_COLLECTION_NAME;
{code}

> in OverseerTest replace strings such as "collection1" and "state"
> -----------------------------------------------------------------
>
>                 Key: SOLR-8338
>                 URL: https://issues.apache.org/jira/browse/SOLR-8338
>             Project: Solr
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8338.patch
>
>
> replace with variable or enum equivalent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to