[ 
https://issues.apache.org/jira/browse/SOLR-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004209#comment-15004209
 ] 

Mike Drob commented on SOLR-8288:
---------------------------------

bq. +        if (leaderCoreNodeName != null && 
cloudDesc.getCoreNodeName().equals(leaderCoreNodeName) // we are still same 
leader
This null check is not necessary.


Is it worth adding a test where a node tries to put itself into recovery? Not 
sure if that's something that is actually possible to stub out.

> DistributedUpdateProcessor#doFinish should explicitly check and ensure it 
> does not try to put itself into LIR.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8288
>                 URL: https://issues.apache.org/jira/browse/SOLR-8288
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: SOLR-8288.patch
>
>
> We have to be careful about this because currently, something like a commit 
> is sent over http even to the local node and if that fails for some reason, 
> the leader might try and LIR itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to