Hi Daniel, Your patch could indeed make things more efficient when merging top hits from many shards, and the code is still easy to read, so +1 to create a JIRA issue. I'm not surprised that ant test did not get faster as we rarely call this method when running tests, maybe you can try to write a simple micro benchmark from randomly generated TopDocs instances?
Le dim. 1 nov. 2015 à 23:39, Daniel Jeliński <[email protected]> a écrit : > Hello all, > The function TopDocs.merge uses PriorityQueue in a pattern: pop, update > value (ref.hitIndex++), add. JavaDocs for PriorityQueue.updateTop > <http://grepcode.com/file/repo1.maven.org/maven2/org.apache.lucene/lucene-core/5.2.0/org/apache/lucene/util/PriorityQueue.java#204> > say that using this function instead should be at least twice as fast. > Would a patch like the one attached be acceptable? Should I create a JIRA > issue for it? > I tried comparing the time taken to run ant test before and after the > patch was applied, but apparently it was affected by random factors more > than it was affected by the patch, so I don't have any performance numbers > to show if / how much it changed. Is there any standard way of benchmarking? > Regards, > Daniel > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected]
