[
https://issues.apache.org/jira/browse/SOLR-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976759#comment-14976759
]
Christine Poerschke commented on SOLR-8196:
-------------------------------------------
Never too late to nitpick. I agree the optional array of paths solution is not
that nice. Historically e.g. in
https://github.com/apache/lucene-solr/blob/lucene_solr_4_8/solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java
{{MiniSolrCloudCluster}} created the directory itself but that got moved up to
the caller (haven't yet delved into when or why) subsequently. Conceptually if
the caller passed something that could create subdirectories then
MiniSolrCloudCluster could create as many or as few subdirectories as are
needed.
Semi-related ticket, SOLR-7886 for factoring out a
{{TestMiniSolrCloudClusterBase}} class (these comments here for
{{MiniSolrCloudCluster}} itself).
> TestMiniSolrCloudCluster.testStopAllStartAll case plus necessary
> MiniSolrCloudCluster tweak
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-8196
> URL: https://issues.apache.org/jira/browse/SOLR-8196
> Project: Solr
> Issue Type: Test
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-8196.patch
>
>
> Background to this seemingly boring
> {{TestMiniSolrCloudCluster.testStopAllStartAll}} case is trying to reproduce
> leadership/election issues observed whilst evaluating 4.10.4 - neither
> branch_5x nor trunk had the issues but {{MiniSolrCloudCluster}} needed a
> little tweak to make the test case work: if the same solr/jetty home
> directory is used for multiple jetties then stopping and starting resulted in
> them all discovering the same cores ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
