[
https://issues.apache.org/jira/browse/SOLR-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975404#comment-14975404
]
Gregory Chanan commented on SOLR-7928:
--------------------------------------
Looks good. Some questions/comments:
{code}
// Need to be public for CheckHdfsIndex
public String indexPath = null;
public String dirImpl = null;
public PrintStream out = null;
{code}
You just need to read these publicly right? Perhaps just write public
accessors? I'm also not sure why you want to possibly modify "out", but not a
big deal.
Testing of the HdfsCheckIndex looks pretty minimal...can we reuse
TestCheckIndex in some way? I'm thinking like changing each test in there to
just take a directory that you pass in. In lucene we use newDirectory, in your
test we use an HdfsDirectory. Thoughts?
{code}
try (Directory dir = directory; CheckIndex checker = new CheckIndex(dir)) {
opts.out = System.out;
return checker.doCheck(opts);
}
{code}
Any plans to write a MapReduce Tool to do this? :)
> Improve CheckIndex to work against HdfsDirectory
> ------------------------------------------------
>
> Key: SOLR-7928
> URL: https://issues.apache.org/jira/browse/SOLR-7928
> Project: Solr
> Issue Type: New Feature
> Components: hdfs
> Reporter: Mike Drob
> Assignee: Gregory Chanan
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-7928.patch, SOLR-7928.patch
>
>
> CheckIndex is very useful for testing an index for corruption. However, it
> can only work with an index on an FSDirectory, meaning that if you need to
> check an Hdfs Index, then you have to download it to local disk (which can be
> very large).
> We should have a way to natively check index on hdfs for corruption.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
