[ 
https://issues.apache.org/jira/browse/SOLR-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972671#comment-14972671
 ] 

Erick Erickson commented on SOLR-8033:
--------------------------------------

[~songwang] It's pretty easy, assuming you have subversion on your machine, 
just switch to the base directory (the parent of solr) and type:
svn diff > SOLR-8033.patch

If you have an IDE, there's usually a "vcs" menu and an option to create a 
patch.

There's lots of detail here:
https://wiki.apache.org/solr/HowToContribute#Generating_a_patch



> useless if branch (commented out log.debug in HdfsTransactionLog constructor)
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-8033
>                 URL: https://issues.apache.org/jira/browse/SOLR-8033
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0, 5.1
>            Reporter: songwanging
>            Assignee: Christine Poerschke
>            Priority: Minor
>
> In method HdfsTransactionLog() of class HdfsTransactionLog 
> (solr\core\src\java\org\apache\solr\update\HdfsTransactionLog.java)
> The if branch presented in the following code snippet performs no actions, we 
> should add more code to handle this or directly delete this if branch.
> HdfsTransactionLog(FileSystem fs, Path tlogFile, Collection<String> 
> globalStrings, boolean openExisting) {
>   ...
>     try {
>       if (debug) {
>         //log.debug("New TransactionLog file=" + tlogFile + ", exists=" + 
> tlogFile.exists() + ", size=" + tlogFile.length() + ", openExisting=" + 
> openExisting);
>       }
> ...
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to