[
https://issues.apache.org/jira/browse/SOLR-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970989#comment-14970989
]
Shawn Heisey edited comment on SOLR-6239 at 10/23/15 1:52 PM:
--------------------------------------------------------------
An audit of my code revealed that this was the only place I was synchronizing
on a Boolean (or any other object that might be globally defined), so it was
likely safe ... but based on what you said it's a bad practice, so I used
"private static Object initSync;" instead.
Edit: After further thought I realized that the code wasn't safe even thought
it's the only instance where I'm using Boolean, because of the possibility of
some instances synchronizing on Boolean.TRUE and others synchronizing on
Boolean.FALSE. The initialization code isn't currently multi-threaded so that
situation can't come up, but I wanted the object to be threadsafe, and it
wasn't. Thank you for bringing my coding problem to my attention.
was (Author: elyograg):
An audit of my code revealed that this was the only place I was synchronizing
on a Boolean (or any other object that might be globally defined), so it was
likely safe ... but based on what you said it's a bad practice, so I used
"private static Object initSync;" instead.
> HttpSolrServer: connection still allocated
> ------------------------------------------
>
> Key: SOLR-6239
> URL: https://issues.apache.org/jira/browse/SOLR-6239
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.9
> Reporter: Sergio Fernández
> Priority: Minor
>
> In scenarios where concurrency is aggressive, this exception could easily
> appear:
> {quote}
> org.apache.solr.client.solrj.impl.HttpSolrServer$RemoteSolrException: Invalid
> use of BasicClientConnManager: connection still allocated.
> Make sure to release the connection before allocating another one.
> at
> org.apache.solr.client.solrj.impl.HttpSolrServer.executeMethod(HttpSolrServer.java:554)
> ~[solr-solrj-4.9.0.jar:4.9.0 1604085 - rmuir - 2014-06-20 06:34:04]
> at
> org.apache.solr.client.solrj.impl.HttpSolrServer.request(HttpSolrServer.java:210)
> ~[solr-solrj-4.9.0.jar:4.9.0 1604085 - rmuir - 2014-06-20 06:34:04]
> at
> org.apache.solr.client.solrj.impl.HttpSolrServer.request(HttpSolrServer.java:206)
> ~[solr-solrj-4.9.0.jar:4.9.0 1604085 - rmuir - 2014-06-20 06:34:04]
> at
> org.apache.solr.client.solrj.request.AbstractUpdateRequest.process(AbstractUpdateRequest.java:124)
> ~[solr-solrj-4.9.0.jar:4.9.0 1604085 - rmuir - 2014-06-20 06:34:04]
> at org.apache.solr.client.solrj.SolrServer.add(SolrServer.java:116)
> ~[solr-solrj-4.9.0.jar:4.9.0 1604085 - rmuir - 2014-06-20 06:34:04]
> at org.apache.solr.client.solrj.SolrServer.add(SolrServer.java:102)
> ~[solr-solrj-4.9.0.jar:4.9.0 1604085 - rmuir - 2014-06-20 06:34:04]
> {quote}
> I wonder if there is any solution for it?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
