[
https://issues.apache.org/jira/browse/LUCENE-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902313#comment-14902313
]
Michael McCandless commented on LUCENE-6780:
--------------------------------------------
I factored out a common test base class, for TestBKDTree and TestGeoPointQuery,
and in the process found a test bug in
{{TestGeoPointQuery.bboxQueryCanBeWrong}} where it was being way too lenient in
returning {{true}}.
I fixed that to instead check whether {{GeoUtils.compare}} returns 0.0 for any
of the rect's boundaries, but now there are new test failures, e.g.:
{noformat}
[junit4] Started J0 PID(11346@localhost).
[junit4] Suite: org.apache.lucene.search.TestGeoPointQuery
[junit4] 1>
TEST-TestGeoPointQuery.testMultiValued-seed#[880EAE9C08D4DB54]: id=4591
docID=4591 should not match but did
[junit4] 1> rect=GeoRect(lon=-153.18749899012866 TO -152.61749242472143
lat=33.44312055800268 TO 33.95438073558091)
[junit4] 1> lat=32.553960682161375 lon=-154.2675789624302
[junit4] 1> lat=33.95438025524065 lon=-152.86846841320704
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestGeoPointQuery
-Dtests.method=testMultiValued -Dtests.seed=880EAE9C08D4DB54 -Dtests.slow=true
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed
-Dtests.locale=nl_BE -Dtests.timezone=Europe/Tallinn -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
[junit4] FAILURE 10.7s | TestGeoPointQuery.testMultiValued <<<
[junit4] > Throwable #1: java.lang.AssertionError: some hits were wrong
[junit4] > at
__randomizedtesting.SeedInfo.seed([880EAE9C08D4DB54:5C2ECAAEC6169B1C]:0)
[junit4] > at
org.apache.lucene.util.BaseGeoPointTestCase.testMultiValued(BaseGeoPointTestCase.java:280)
[junit4] > at java.lang.Thread.run(Thread.java:745)
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene53):
{id=PostingsFormat(name=LuceneVarGapFixedInterval),
point=PostingsFormat(name=Asserting)},
docValues:{point=DocValuesFormat(name=Asserting)}, sim=ClassicSimilarity,
locale=nl_BE, timezone=Europe/Tallinn
[junit4] 2> NOTE: Linux 3.13.0-61-generic amd64/Oracle Corporation
1.8.0_40 (64-bit)/cpus=8,threads=1,free=366930072,total=501219328
[junit4] 2> NOTE: All tests run in this JVM: [TestGeoPointQuery]
[junit4] Completed [1/1] in 11.10s, 1 test, 1 failure <<< FAILURES!
{noformat}
The failure is clearly a boundary case, so maybe we just need a better "is
boundary case" check?
It's also entirely possible I created new exciting test bugs in the refactoring
:)
And we still have the test failures for both BKD and GeoPoint distance queries
when distance is biggish...
> GeoPointDistanceQuery doesn't work with a large radius?
> -------------------------------------------------------
>
> Key: LUCENE-6780
> URL: https://issues.apache.org/jira/browse/LUCENE-6780
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Attachments: LUCENE-6780.patch, LUCENE-6780.patch, LUCENE-6780.patch,
> LUCENE-6780.patch, LUCENE-6780.patch
>
>
> I'm working on LUCENE-6698 but struggling with test failures ...
> Then I noticed that TestGeoPointQuery's test never tests on large distances,
> so I modified the test to sometimes do so (like TestBKDTree) and hit test
> failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
