[ 
https://issues.apache.org/jira/browse/SOLR-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14719985#comment-14719985
 ] 

Mark Miller commented on SOLR-7956:
-----------------------------------

{code}
       try {
+        // we allow interrupts because ref counted closing is done - we want 
out
         ExecutorUtil.shutdownNowAndAwaitTermination(recoveryExecutor);
       } catch (Exception e) {
{code}

Whoops - I'll flip that one too. I think it's fine, but if we can take out all 
use, it simplifies things a bit.

> There are interrupts on shutdown in places that can cause 
> ChannelAlreadyClosed exceptions which prevents proper closing of transaction 
> logs.
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7956
>                 URL: https://issues.apache.org/jira/browse/SOLR-7956
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: Trunk, 5.4
>
>         Attachments: SOLR-7956.patch, SOLR-7956.patch
>
>
> Found this while beast testing HttpPartitionTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to