[ 
https://issues.apache.org/jira/browse/SOLR-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708024#comment-14708024
 ] 

Shawn Heisey commented on SOLR-7850:
------------------------------------

I've had some time for my thoughts to gel on this subject.

I think that we should move the bin/solr.in.* scripts to something like 
etc/startupenv.* instead, and place versions with "sample" in the filename in 
the download.  I've thought about placing those sample files in server/etc 
instead, since that directory already exists. I'm open to discussion on both 
the filenames and the location.  I like the idea of an etc directory at the top 
level ... if most of what a user might want to change in server/etc is 
configurable by environment variables in etc (I think we're probably there or 
mostly there now), we can hopefully keep beginners from messing with the jetty 
config and permanent scripts directly.

The main solr script should contain sensible defaults for the variables that 
can be overridden in the startup environment, then read that config script if 
it exists.


> Move user customization out of solr.in.* scripts
> ------------------------------------------------
>
>                 Key: SOLR-7850
>                 URL: https://issues.apache.org/jira/browse/SOLR-7850
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>    Affects Versions: 5.2.1
>            Reporter: Shawn Heisey
>            Priority: Minor
>
> I've seen a fair number of users customizing solr.in.* scripts to make 
> changes to their Solr installs.  I think the documentation suggests this, 
> though I haven't confirmed.
> One possible problem with this is that we might make changes in those scripts 
> which such a user would want in their setup, but if they replace the script 
> with the one in the new version, they will lose their customizations.
> I propose instead that we have the startup script look for and utilize a user 
> customization script, in a similar manner to linux init scripts that look for 
> /etc/default/packagename, but are able to function without it.  I'm not 
> entirely sure where the script should live or what it should be called.  One 
> idea is server/etc/userconfig.\{sh,cmd\} ... but I haven't put a lot of 
> thought into it yet.
> If the internal behavior of our scripts is largely replaced by a small java 
> app as detailed in SOLR-7043, then the same thing should apply there -- have 
> a config file for a user to specify settings, but work perfectly if that 
> config file is absent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to