[
https://issues.apache.org/jira/browse/LUCENE-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699546#comment-14699546
]
Michael McCandless commented on LUCENE-6699:
--------------------------------------------
[~daddywri] I committed the patch but svn got a bit furious:
{noformat}
mike@haswell:/l/3dbkd$ svn patch patch.x
U
lucene/spatial/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShape.java
C
lucene/spatial/src/test/org/apache/lucene/spatial/spatial4j/Geo3dShapeRectRelationTestCase.java
> rejected hunk @@ -58,7 +58,8 @@
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/Bounds.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoBaseShape.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoCircle.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoCompositeMembershipShape.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoConvexPolygon.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoDegenerateHorizontalLine.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoDegenerateLatitudeZone.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoDegenerateLongitudeSlice.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoDegeneratePoint.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoDegenerateVerticalLine.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoLatitudeZone.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoLongitudeSlice.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoNorthLatitudeZone.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoNorthRectangle.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoPath.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoRectangle.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoShape.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoSouthLatitudeZone.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoSouthRectangle.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoWideDegenerateHorizontalLine.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoWideLongitudeSlice.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoWideNorthRectangle.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoWideRectangle.java
U
lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoWideSouthRectangle.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/GeoWorld.java
A lucene/spatial3d/src/java/org/apache/lucene/geo3d/LatLonBounds.java
U lucene/spatial3d/src/java/org/apache/lucene/geo3d/Plane.java
A lucene/spatial3d/src/java/org/apache/lucene/geo3d/XYZBounds.java
> hunk @@ -138,7 +138,7 @@ already applied
> hunk @@ -145,6 +145,7 @@ already applied
> hunk @@ -154,6 +155,7 @@ already applied
> hunk @@ -160,12 +162,12 @@ already applied
> hunk @@ -81,7 +81,7 @@ already applied
> hunk @@ -88,6 +88,7 @@ already applied
> hunk @@ -96,18 +97,13 @@ already applied
U lucene/spatial3d/src/test/org/apache/lucene/geo3d/GeoBBoxTest.java
U lucene/spatial3d/src/test/org/apache/lucene/geo3d/GeoCircleTest.java
U
lucene/spatial3d/src/test/org/apache/lucene/geo3d/GeoConvexPolygonTest.java
U lucene/spatial3d/src/test/org/apache/lucene/geo3d/GeoModelTest.java
U lucene/spatial3d/src/test/org/apache/lucene/geo3d/GeoPathTest.java
U lucene/spatial3d/src/test/org/apache/lucene/geo3d/GeoPolygonTest.java
> hunk @@ -27,16 +27,15 @@ already applied
> hunk @@ -67,5 +66,160 @@ already applied
Summary of conflicts:
Text conflicts: 1
{noformat}
I resolved the one conflict by hand, but can you svn up and confirm things look
OK? Tests did pass after applying the patch...
> Integrate lat/lon BKD and spatial3d
> -----------------------------------
>
> Key: LUCENE-6699
> URL: https://issues.apache.org/jira/browse/LUCENE-6699
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Attachments: Geo3DPacking.java, LUCENE-6699.patch, LUCENE-6699.patch,
> LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch,
> LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch, LUCENE-6699.patch
>
>
> I'm opening this for discussion, because I'm not yet sure how to do
> this integration, because of my ignorance about spatial in general and
> spatial3d in particular :)
> Our BKD tree impl is very fast at doing lat/lon shape intersection
> (bbox, polygon, soon distance: LUCENE-6698) against previously indexed
> points.
> I think to integrate with spatial3d, we would first need to record
> lat/lon/z into doc values. Somewhere I saw discussion about how we
> could stuff all 3 into a single long value with acceptable precision
> loss? Or, we could use BinaryDocValues? We need all 3 dims available
> to do the fast per-hit query time filtering.
> But, second: what do we index into the BKD tree? Can we "just" index
> earth surface lat/lon, and then at query time is spatial3d able to
> give me an enclosing "surface lat/lon" bbox for a 3d shape? Or
> ... must we index all 3 dimensions into the BKD tree (seems like this
> could be somewhat wasteful)?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
