[
https://issues.apache.org/jira/browse/SOLR-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695610#comment-14695610
]
Yonik Seeley commented on SOLR-7836:
------------------------------------
bq. Yeah, I saw that comment. In that case, removing the two synchronizations
in the refactored methods other than addAndDelete is probably indicated. The
one in addAndDelete was there originally, just within the IndexWriter
try/finally which is where the issues was since it'd go out and get a new
searcher eventually.
Maybe... but it's also worth noting that those comments (and my thinking around
it) were before (i think) index writers could be shared across reloads.
It looks fine to me that you moved the ulog.add() outside of the writer
get/release.
> Possible deadlock when closing refcounted index writers.
> --------------------------------------------------------
>
> Key: SOLR-7836
> URL: https://issues.apache.org/jira/browse/SOLR-7836
> Project: Solr
> Issue Type: Bug
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Fix For: Trunk, 5.4
>
> Attachments: SOLR-7836-synch.patch, SOLR-7836.patch, SOLR-7836.patch,
> SOLR-7836.patch, deadlock_3.res.zip, deadlock_5_pass_iw.res.zip, deadlock_test
>
>
> Preliminary patch for what looks like a possible race condition between
> writerFree and pauseWriter in DefaultSorlCoreState.
> Looking for comments and/or why I'm completely missing the boat.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
