[ 
https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616349#comment-14616349
 ] 

Shai Erera edited comment on SOLR-7748 at 7/7/15 10:42 AM:
-----------------------------------------------------------

bq. but for J9, it sets the variable and doesn't include what's there previousl

Indeed, and as I put in the comment above that line, on the -Xverbosegclog is 
required/supported by J9, as far as I could tell from the J9 team. Also this 
page which they pointed me at does not indicate any additional parameters are 
needed: 
http://www-01.ibm.com/support/knowledgecenter/SSYKE2_8.0.0/com.ibm.java.win.80.doc/diag/appendixes/cmdline/xverbosegclog.html.

bq. The removed line (replaced with the if/else construct) uses parentheses to 
combine the old with the new,

You're right. At first I thought that the parentheses don't work because when I 
echoed them using {{echo $GC_LOG_OPTS}} it only printed the -verbose:gc. I now 
tried {{echo "$\{GC_LOG_OPTS[@]\}"}} and it works. I'll restore that.


was (Author: shaie):
bq. but for J9, it sets the variable and doesn't include what's there previousl

Indeed, and as I put in the comment above that line, on the -Xverbosegclog is 
required/supported by J9, as far as I could tell from the J9 team. Also this 
page which they pointed me at does not indicate any additional parameters are 
needed: 
http://www-01.ibm.com/support/knowledgecenter/SSYKE2_8.0.0/com.ibm.java.win.80.doc/diag/appendixes/cmdline/xverbosegclog.html.

bq. The removed line (replaced with the if/else construct) uses parentheses to 
combine the old with the new,

You're right. At first I thought that the parentheses don't work because when I 
echoed them using {{echo $GC_LOG_OPTS}} it only printed the -verbose:gc. I now 
tried {{echo "${GC_LOG_OPTS[@]}"}} and it works. I'll restore that.

> Fix bin/solr to work on IBM J9
> ------------------------------
>
>                 Key: SOLR-7748
>                 URL: https://issues.apache.org/jira/browse/SOLR-7748
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 5.3, Trunk
>
>         Attachments: SOLR-7748.patch, SOLR-7748.patch, solr-7748.patch
>
>
> bin/solr doesn't work on IBM J9 because it sets -Xloggc flag, while J9 
> supports -Xverbosegclog. This prevents using bin/solr to start it on J9.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to