[
https://issues.apache.org/jira/browse/LUCENE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614263#comment-14614263
]
Michael McCandless commented on LUCENE-6365:
--------------------------------------------
Hmm this failure just appeared on Jenkins:
{noformat}
[junit4] Started J0 PID(3197@localhost).
[junit4] Suite: org.apache.lucene.util.automaton.FiniteStringsIteratorTest
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=FiniteStringsIteratorTest -Dtests.method=testRandomFiniteStrings1
-Dtests.seed=4A938C5F6E728DCC -Dtests.multiplier=3 -Dtests.slow=true
-Dtests.locale=es_CU -Dtests.timezone=America/Porto_Velho -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
[junit4] FAILURE 0.26s | FiniteStringsIteratorTest.testRandomFiniteStrings1
<<<
[junit4] > Throwable #1: java.lang.AssertionError: expected:<445> but
was:<446>
[junit4] > at
__randomizedtesting.SeedInfo.seed([4A938C5F6E728DCC:17BF51EE97CD2662]:0)
[junit4] > at
org.apache.lucene.util.automaton.FiniteStringsIteratorTest.assertFiniteStringsRecursive(FiniteStringsIteratorTest.java:204)
[junit4] > at
org.apache.lucene.util.automaton.FiniteStringsIteratorTest.testRandomFiniteStrings1(FiniteStringsIteratorTest.java:82)
[junit4] > at java.lang.Thread.run(Thread.java:745)
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene53): {},
docValues:{}, sim=RandomSimilarityProvider(queryNorm=true,coord=no): {},
locale=es_CU, timezone=America/Porto_Velho
[junit4] 2> NOTE: Linux 3.13.0-46-generic amd64/Oracle Corporation
1.8.0_40 (64-bit)/cpus=8,threads=1,free=483134008,total=504889344
[junit4] 2> NOTE: All tests run in this JVM: [FiniteStringsIteratorTest]
[junit4] Completed [1/1] in 0.41s, 1 test, 1 failure <<< FAILURES!
{noformat}
It reproduces ... I haven't dug into it yet.
> Optimized iteration of finite strings
> -------------------------------------
>
> Key: LUCENE-6365
> URL: https://issues.apache.org/jira/browse/LUCENE-6365
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 5.0
> Reporter: Markus Heiden
> Priority: Minor
> Labels: patch, performance
> Fix For: 5.3, Trunk
>
> Attachments: FiniteStrings_noreuse.patch, FiniteStrings_reuse.patch,
> LUCENE-6365.patch
>
>
> Replaced Operations.getFiniteStrings() by an optimized FiniteStringIterator.
> Benefits:
> Avoid huge hash set of finite strings.
> Avoid massive object/array creation during processing.
> "Downside":
> Iteration order changed, so when iterating with a limit, the result may
> differ slightly. Old: emit current node, if accept / recurse. New: recurse /
> emit current node, if accept.
> The old method Operations.getFiniteStrings() still exists, because it eases
> the tests. It is now implemented by use of the new FiniteStringIterator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
