[ 
https://issues.apache.org/jira/browse/LUCENE-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605695#comment-14605695
 ] 

Martijn van Groningen commented on LUCENE-6589:
-----------------------------------------------

bq. Good point about testing the tester, I added a new test to make sure that 
we throw an exception when the index has an illegal structure.

Thanks! 

bq. However I disagree about running this check while running block join 
queries. I think it should considered a heavy operation given that it needs to 
read the whole index and should only be run to ensure that the index has a good 
structure, pretty much like CheckIndex?

true, good point. I was looking for a way to have the ability to run this 
validation easily elsewhere too (via a low level debug option). But having the 
utility available when the join jar is on the class path is good too, systems 
relying on block join can just add this to their testing infrastructure.

+1 to commit! 

> Less leniency in lucene/join
> ----------------------------
>
>                 Key: LUCENE-6589
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6589
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6589.patch, LUCENE-6589.patch
>
>
> The lucene/join module expects a certain index structure but nothing 
> validates it. Then at search time it either needs to validate the index 
> structure in a slow way or be lenient and cope with what it is given.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to