[ 
https://issues.apache.org/jira/browse/SOLR-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601283#comment-14601283
 ] 

Tommaso Teofili commented on SOLR-7719:
---------------------------------------

after applying your patch and launching 'ant compile' on trunk I get:
{code}
common.compile-core:
    [mkdir] Created dir: lucene/trunk/solr/build/solr-solrj/classes/java
    [javac] Compiling 221 source files to 
lucene/trunk/solr/build/solr-solrj/classes/java
    [javac] 
lucene/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/response/SuggesterResponse.java:64:
 error: bad use of '>'
    [javac]    * Getter for the map dictionary name -> List of Suggestion 
objects.
    [javac]                                          ^
    [javac] 
lucene/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/response/SuggesterResponse.java:66:
 error: bad use of '>'
    [javac]    * @return a Map dictionary name -> List of Suggestion
    [javac]                                     ^
    [javac] 
lucene/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/response/SuggesterResponse.java:73:
 error: bad use of '>'
    [javac]    * This getter is lazily initialized and returns a simplified map 
dictionary -> List of suggested terms
    [javac]                                                                     
            ^
    [javac] 
lucene/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/response/SuggesterResponse.java:75:
 error: bad use of '>'
    [javac]    * @return a Map dictionary name -> List of suggested terms
    [javac]                                     ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 4 errors
{code}

I adapted the patch myself (substituted the -> chars with : in javadocs), the 
patch then compiles correctly and tests pass.



> Suggester Component results parsing
> -----------------------------------
>
>                 Key: SOLR-7719
>                 URL: https://issues.apache.org/jira/browse/SOLR-7719
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>    Affects Versions: 5.2.1
>            Reporter: Alessandro Benedetti
>            Assignee: Tommaso Teofili
>            Priority: Minor
>              Labels: queryResponse, suggester, suggestions
>         Attachments: SOLR-7719.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently SolrJ org.apache.solr.client.solrj.response.QueryResponse is not 
> managing suggestions coming from the Suggest Component .
> It would be nice to have the suggestions properly managed and returned with 
> simply getter methods.
> Current Json :
> <lst name="suggest">
>     <lst name="dictionary1">
>         <lst name="queryTerm">
>         <int name="numFound">2</int>
>         <arr name="suggestions">
>        <lst>
>            <str name="term">suggestion1</str>..
>            <str name="term">suggestion2</str>…
>        </lst>
>        </arr>
>        </lst>
>        </lst>..
> This will be parsed accordingly .
> Producing an easy to use Java Map.
> Dictionary2suggestions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to