[
https://issues.apache.org/jira/browse/LUCENE-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989081#comment-12989081
]
Doron Cohen commented on LUCENE-1540:
-------------------------------------
Thanks for the review Shai!
All comments accepted.
Good catch with the int[] - added that sometimes and forgot to cleanup.
I think ZIP can wait for another day - let's get this one in.
Note that we are using
[CompressorInputStream.createCompressorInputStream()|http://commons.apache.org/compress/apidocs/org/apache/commons/compress/compressors/CompressorStreamFactory.html#createCompressorInputStream(java.lang.String,%20java.io.InputStream)]
which at version 1.1 only supports BZIP2 and GZIP. But the docs for Compress
specify ZIP as well - so I guess this is possible, just needs a deeper dig
into, in another issue, which, I guess, should also upgrade benchmark/compress
from 1.0 to 1.1 (solr already uses 1.1).
bq. do you think the performance gain (of not allocating a String in the SB
variant) is worth the code dup?
I think so, it is a rather short method, will add a javadoc clarification.
> Improvements to contrib.benchmark for TREC collections
> ------------------------------------------------------
>
> Key: LUCENE-1540
> URL: https://issues.apache.org/jira/browse/LUCENE-1540
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/benchmark
> Reporter: Tim Armstrong
> Assignee: Doron Cohen
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-1540.patch, LUCENE-1540.patch
>
>
> The benchmarking utilities for TREC test collections (http://trec.nist.gov)
> are quite limited and do not support some of the variations in format of
> older TREC collections.
> I have been doing some benchmarking work with Lucene and have had to modify
> the package to support:
> * Older TREC document formats, which the current parser fails on due to
> missing document headers.
> * Variations in query format - newlines after <title> tag causing the query
> parser to get confused.
> * Ability to detect and read in uncompressed text collections
> * Storage of document numbers by default without storing full text.
> I can submit a patch if there is interest, although I will probably want to
> write unit tests for the new functionality first.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
