[ 
https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582195#comment-14582195
 ] 

Shalin Shekhar Mangar commented on SOLR-7344:
---------------------------------------------

I like this approach too. 

{quote}
 An application can provide a custom {@link RequestSchedulingPolicy} via a
 * Java system property named 'requestPolicyClassName'. This policy
 * implementation needs to provide the necessary configuration parameters
 * required by this filter viz.
 * - A list of request types accepted by the application. (Note - this list 
must be
 *   exhaustive i.e. it should cover *all* requests processed by the 
application).
{quote}

I don't think it is practical to require that the request type list be 
exhaustive because of the pace of Solr's development and custom components. A 
good default should be provided.

Minor nit: typo in "golbalProcessingTime" in RequestSchedulerFilter.

> Use two thread pools, one for internal requests and one for external, to 
> avoid distributed deadlock and decrease the number of threads that need to be 
> created.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7344
>                 URL: https://issues.apache.org/jira/browse/SOLR-7344
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Mark Miller
>         Attachments: SOLR-7344.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to