[ 
https://issues.apache.org/jira/browse/LUCENE-2897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988481#action_12988481
 ] 

Michael McCandless commented on LUCENE-2897:
--------------------------------------------

bq. Instead we're building the deleted docs BV as we're flushing.

Right, that's what the patch does.  Seems to work great :)

bq. I was thinking we'd switch to live deletes with RT, because then we can 
also handle delete-by-query like this.

Right, though for RT we need to apply the delete immediately (vs this patch 
which applies on flush).

And delete-by-Query is still buffered...

> apply delete-by-Term and docID immediately to newly flushed segments
> --------------------------------------------------------------------
>
>                 Key: LUCENE-2897
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2897
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2897.patch
>
>
> Spinoff from LUCENE-2324.
> When we flush deletes today, we keep them as buffered Term/Query/docIDs that 
> need to be deleted.  But, for a newly flushed segment (ie fresh out of the 
> DWPT), this is silly, because during flush we visit all terms and we know 
> their docIDs.  So it's more efficient to apply the deletes (for this one 
> segment) at that time.
> We still must buffer deletes for all prior segments, but these deletes don't 
> need to map to a docIDUpto anymore; ie we just need a Set.
> This issue should wait until LUCENE-1076 is in since that issue cuts over 
> buffered deletes to a transactional stream.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to