I posted a fix on the review board. Basically, the change replaces the current colinearity check with one directly related to the computation of the segment endpoint plane.
Karl On Wed, Jun 3, 2015 at 5:51 AM, Karl Wright <[email protected]> wrote: > There is already a check for a degenerate path segment. > > This is happening because the endpoints that define two path segments are > co-linear. There's a check for that too, but clearly it's not firing > properly in this case for some reason. > > I'll have to look deeper when I have a chance. It may be a little while > because I'm currently in a crunch. > > Karl > > > On Tue, Jun 2, 2015 at 11:44 PM, [email protected] < > [email protected]> wrote: > >> Can you take a look Karl? >> At first glance looking at the code, not running it, I’m guessing this is >> a degenerate path segment that is too short. >> >> On Tue, Jun 2, 2015 at 11:19 PM Policeman Jenkins Server < >> [email protected]> wrote: >> >>> Build: http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/2377/ >>> Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseConcMarkSweepGC >>> >>> 1 tests failed. >>> FAILED: org.apache.lucene.spatial.spatial4j.Geo3dRptTest.testOperations >>> {#2 seed=[4AB0FA45EF43F0C3:2240DF3E6EDF83C]} >>> >>> Error Message: >>> >>> >>> Stack Trace: >>> java.lang.NullPointerException >>> at >>> __randomizedtesting.SeedInfo.seed([4AB0FA45EF43F0C3:2240DF3E6EDF83C]:0) >>> at >>> org.apache.lucene.spatial.spatial4j.geo3d.GeoPath$SegmentEndpoint.<init>(GeoPath.java:480) >>> at >>> org.apache.lucene.spatial.spatial4j.geo3d.GeoPath.done(GeoPath.java:121) >>> at >>> org.apache.lucene.spatial.spatial4j.Geo3dRptTest.randomQueryShape(Geo3dRptTest.java:195) >>> at >>> org.apache.lucene.spatial.prefix.RandomSpatialOpStrategyTestCase.testOperationRandomShapes(RandomSpatialOpStrategyTestCase.java:53) >>> at >>> org.apache.lucene.spatial.spatial4j.Geo3dRptTest.testOperations(Geo3dRptTest.java:100) >>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>> at >>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>> at >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>> at java.lang.reflect.Method.invoke(Method.java:497) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1627) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:836) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:872) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:886) >>> at >>> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:50) >>> at >>> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46) >>> at >>> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:49) >>> at >>> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:65) >>> at >>> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) >>> at >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>> at >>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:365) >>> at >>> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:798) >>> at >>> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:458) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:845) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(RandomizedRunner.java:747) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:781) >>> at >>> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:792) >>> at >>> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46) >>> at >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>> at >>> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42) >>> at >>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39) >>> at >>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39) >>> at >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>> at >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>> at >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>> at >>> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:54) >>> at >>> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) >>> at >>> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:65) >>> at >>> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:55) >>> at >>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>> at >>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:365) >>> at java.lang.Thread.run(Thread.java:745) >>> >>> >>> >>> >>> Build Log: >>> [...truncated 8066 lines...] >>> [junit4] Suite: org.apache.lucene.spatial.spatial4j.Geo3dRptTest >>> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=Geo3dRptTest >>> -Dtests.method=testOperations -Dtests.seed=4AB0FA45EF43F0C3 >>> -Dtests.slow=true -Dtests.locale=sq -Dtests.timezone=Pacific/Samoa >>> -Dtests.asserts=true -Dtests.file.encoding=US-ASCII >>> [junit4] ERROR 0.17s J0 | Geo3dRptTest.testOperations {#2 >>> seed=[4AB0FA45EF43F0C3:2240DF3E6EDF83C]} <<< >>> [junit4] > Throwable #1: java.lang.NullPointerException >>> [junit4] > at >>> __randomizedtesting.SeedInfo.seed([4AB0FA45EF43F0C3:2240DF3E6EDF83C]:0) >>> [junit4] > at >>> org.apache.lucene.spatial.spatial4j.geo3d.GeoPath$SegmentEndpoint.<init>(GeoPath.java:480) >>> [junit4] > at >>> org.apache.lucene.spatial.spatial4j.geo3d.GeoPath.done(GeoPath.java:121) >>> [junit4] > at >>> org.apache.lucene.spatial.spatial4j.Geo3dRptTest.randomQueryShape(Geo3dRptTest.java:195) >>> [junit4] > at >>> org.apache.lucene.spatial.prefix.RandomSpatialOpStrategyTestCase.testOperationRandomShapes(RandomSpatialOpStrategyTestCase.java:53) >>> [junit4] > at >>> org.apache.lucene.spatial.spatial4j.Geo3dRptTest.testOperations(Geo3dRptTest.java:100) >>> [junit4] > at java.lang.Thread.run(Thread.java:745) >>> [junit4] 2> NOTE: test params are: >>> codec=DummyCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=DUMMY, >>> chunkSize=4, maxDocsPerChunk=9, blockSize=313), >>> termVectorsFormat=CompressingTermVectorsFormat(compressionMode=DUMMY, >>> chunkSize=4, blockSize=313)), >>> sim=RandomSimilarityProvider(queryNorm=false,coord=yes): {}, locale=sq, >>> timezone=Pacific/Samoa >>> [junit4] 2> NOTE: Mac OS X 10.8.5 x86_64/Oracle Corporation >>> 1.8.0_45 (64-bit)/cpus=3,threads=1,free=25499848,total=54788096 >>> [junit4] 2> NOTE: All tests run in this JVM: [DateNRStrategyTest, >>> GeoPointTest, TestRecursivePrefixTreeStrategy, Geo3dRptTest] >>> [junit4] Completed [8/31] on J0 in 1.13s, 11 tests, 1 error <<< >>> FAILURES! >>> >>> [...truncated 83 lines...] >>> BUILD FAILED >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/build.xml:526: The >>> following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/build.xml:474: The >>> following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/build.xml:61: The >>> following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/extra-targets.xml:39: >>> The following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/lucene/build.xml:466: >>> The following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/lucene/common-build.xml:2148: >>> The following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/lucene/module-build.xml:58: >>> The following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/lucene/common-build.xml:1418: >>> The following error occurred while executing this line: >>> /Users/jenkins/workspace/Lucene-Solr-trunk-MacOSX/lucene/common-build.xml:973: >>> There were test failures: 31 suites, 271 tests, 1 error, 3 ignored (2 >>> assumptions) >>> >>> Total time: 23 minutes 46 seconds >>> Build step 'Invoke Ant' marked build as failure >>> Archiving artifacts >>> Recording test results >>> Email was triggered for: Failure - Any >>> Sending email for trigger: Failure - Any >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >> >> >
