[ 
https://issues.apache.org/jira/browse/SOLR-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567843#comment-14567843
 ] 

Hoss Man commented on SOLR-7615:
--------------------------------

bq. It's just a bit trappy. Perhaps we should always be creating it.

+0 ... it's a factory optimization to only create/inject the processor if it 
has some purpose for existing.

it probably saves a few cycles for some people, but if the optimization is 
getting in hte way of the maintainability of the code, by all means rip it out.

> Slow update requests not logged at WARN due to how LogUpdateProcessor's are 
> created
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-7615
>                 URL: https://issues.apache.org/jira/browse/SOLR-7615
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Timothy Potter
>            Assignee: Timothy Potter
>            Priority: Minor
>
> In SOLR-6650, we introduced the ability to only have slow update and query 
> requests get logged as warnings. However, when tracking down the cause of 
> SOLR-7603, we discovered that the LogUpdateProcessor is only included in the 
> chain if the log has INFO enabled, thus rendering the solution provided by 
> SOLR-6650 useless for update requests (queries still work though).
> Thus, we need to fix how LogUpdateProcessor is created if the user has 
> configured slowUpdateThresholdMillis > 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to