[
https://issues.apache.org/jira/browse/LUCENE-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-6508:
----------------------------------
Attachment: LUCENE-6508.patch
I like your proposal. I already worked with it and implemented the lock factory
tester:
ant test-lock-factory passes successfully.
I also changed the javadocs a bit and renamed the ValidatingDirectoryWrapper to
LockValidatingDirectoryWrapper. We have way too many validating wrappers, so we
should have the term "Lock" in the name :-)
While implementing the lock stress tester, I noticed that it is now very hard
to differentiate between an conventional I/O error and failure to obtain the
lock. Maybe we should still "preserve" LockObtainFailed Exception. I am not so
happy with having no Exception anymore that clearly states that the lock was
not successfully obtained (also for users).
> Simplify Directory/lock api
> ---------------------------
>
> Key: LUCENE-6508
> URL: https://issues.apache.org/jira/browse/LUCENE-6508
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Attachments: LUCENE-6508-deadcode1.patch, LUCENE-6508.patch,
> LUCENE-6508.patch
>
>
> See LUCENE-6507 for some background. In general it would be great if you can
> just acquire an immutable lock (or you get a failure) and then you close that
> to release it.
> Today the API might be too much for what is needed by IW.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]