[
https://issues.apache.org/jira/browse/SOLR-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562517#comment-14562517
]
Shalin Shekhar Mangar commented on SOLR-7599:
---------------------------------------------
bq. Yes, it is required. It ensures that the state is indeed saved in the
state.json .
Okay, I will rename ExternalCollectionsTest to CollectionStateFormat2Test. I
will also move the .system collection test from this test file to its own so
that it is easier to find. Better not to mix unrelated tests together in test
class.
I also noticed that DeleteLastCustomShardedReplicaTest is ignored on trunk but
not on branch_5x. Since I haven't seen this test failing on branch_5x, I will
re-enable this test on trunk and investigate if it fails again.
> Remove cruft from SolrCloud tests
> ---------------------------------
>
> Key: SOLR-7599
> URL: https://issues.apache.org/jira/browse/SOLR-7599
> Project: Solr
> Issue Type: Task
> Components: SolrCloud, Tests
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 5.3
>
> Attachments: SOLR-7599.patch
>
>
> I see many tests which blindly have distribSetUp and distribTearDown methods
> setting a variety of options and system properties that aren't required
> anymore.
> This is because some base test classes have been refactored such that these
> options are redundant. In other cases, people have copied the structure of
> tests blindly instead of understanding what each parameter does.
> Let's try to remove the unnecessary config params from such tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
